Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 343603003: Calculate the tabstrip min width based on the actual tabs in the strip. (Closed)

Created:
6 years, 6 months ago by Peter Kasting
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Calculate the tabstrip min width based on the actual tabs in the strip. The maximum minimum width is the width required to show 20 tabs at minimum size. In my testing, that resulted in an overall window width of 440 pixels. This is narrow enough that I doubt this minimum will kick in very often, and when it does, it won't be dramatically larger than the minimum width the toolbar already enforces. BUG=62510 TEST=Open 20 tabs. Shrink Chrome window to minimum width and ensure all tabs are still visible. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +31 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Kasting
6 years, 6 months ago (2014-06-19 00:45:42 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-19 15:28:45 UTC) #2
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 6 months ago (2014-06-19 17:42:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/343603003/1
6 years, 6 months ago (2014-06-19 17:46:58 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 20:11:39 UTC) #5
Message was sent while issue was closed.
Change committed as 278470

Powered by Google App Engine
This is Rietveld 408576698