Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: content/plugin/plugin_channel.cc

Issue 343593006: Revert 276939 "Decouple IPC::MessageFilter from IPC::Channel" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2057/src/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/plugin/plugin_channel.cc
===================================================================
--- content/plugin/plugin_channel.cc (revision 278168)
+++ content/plugin/plugin_channel.cc (working copy)
@@ -43,7 +43,7 @@
// happen in a single process browser and avoid deadlock.
class PluginChannel::MessageFilter : public IPC::MessageFilter {
public:
- MessageFilter() : sender_(NULL) { }
+ MessageFilter() : channel_(NULL) { }
base::WaitableEvent* GetModalDialogEvent(int render_view_id) {
base::AutoLock auto_lock(modal_dialog_event_map_lock_);
@@ -75,12 +75,12 @@
bool Send(IPC::Message* message) {
// Need this function for the IPC_MESSAGE_HANDLER_DELAY_REPLY macro.
- return sender_->Send(message);
+ return channel_->Send(message);
}
// IPC::MessageFilter:
- virtual void OnFilterAdded(IPC::Sender* sender) OVERRIDE {
- sender_ = sender;
+ virtual void OnFilterAdded(IPC::Channel* channel) OVERRIDE {
+ channel_ = channel;
}
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE {
@@ -138,7 +138,7 @@
ModalDialogEventMap modal_dialog_event_map_;
base::Lock modal_dialog_event_map_lock_;
- IPC::Sender* sender_;
+ IPC::Channel* channel_;
};
PluginChannel* PluginChannel::GetPluginChannel(
« no previous file with comments | « content/common/gpu/media/gpu_video_decode_accelerator.cc ('k') | content/public/browser/browser_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698