Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.h

Issue 343593006: Revert 276939 "Decouple IPC::MessageFilter from IPC::Channel" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2057/src/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_dispatcher_host.h
===================================================================
--- content/browser/service_worker/service_worker_dispatcher_host.h (revision 278168)
+++ content/browser/service_worker/service_worker_dispatcher_host.h (working copy)
@@ -32,13 +32,13 @@
void Init(ServiceWorkerContextWrapper* context_wrapper);
// BrowserMessageFilter implementation
- virtual void OnFilterAdded(IPC::Sender* sender) OVERRIDE;
+ virtual void OnFilterAdded(IPC::Channel* channel) OVERRIDE;
virtual void OnDestruct() const OVERRIDE;
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
// IPC::Sender implementation
- // Send() queues the message until the underlying sender is ready. This
+ // Send() queues the message until the underlying channel is ready. This
// class assumes that Send() can only fail after that when the renderer
// process has terminated, at which point the whole instance will eventually
// be destroyed.
@@ -117,7 +117,7 @@
IDMap<ServiceWorkerHandle, IDMapOwnPointer> handles_;
- bool channel_ready_; // True after BrowserMessageFilter::sender_ != NULL.
+ bool channel_ready_; // True after BrowserMessageFilter::channel_ != NULL.
ScopedVector<IPC::Message> pending_messages_;
DISALLOW_COPY_AND_ASSIGN(ServiceWorkerDispatcherHost);

Powered by Google App Engine
This is Rietveld 408576698