Issue 343583002: Make the internal parts of our external API a bit more const-correct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343583002: Make the internal parts of our external API a bit more const-correct. (Closed)

Created:
6 years, 6 months ago by Sven Panne

Modified:
6 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make the internal parts of our external API a bit more const-correct. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21891

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -16 lines)			Patch
	M	include/v8.h	View		6 chunks	+18 lines, -16 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/343583002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/343583002/diff/1/include/v8.h#newcode5638 include/v8.h:5638: kIsolateEmbedderDataOffset + slot * kApiPointerSize; nit: There are ...

6 years, 6 months ago (2014-06-18 13:48:16 UTC) #2

Sven Panne

6 years, 6 months ago (2014-06-20 07:20:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21891 (presubmit successful).

Expand Messages | Collapse Messages