Fix stack trace accessor behavior.

Fix stack trace accessor behavior.

R=verwaest@chromium.org
BUG=v8:3404
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=22089

[Yang, 2014-06-26 13:47:27]

On 2014/06/26 11:21:52, Yang wrote:

addressed offline comments. Now the setter doesn't do anything if invoked on
anything else than the holder of the raw stack trace.

[Toon Verwaest, 2014-06-26 14:50:44]

As discussed offline, I'd drop support for derived objects, this is just too
annoying.

Also, setting "stack" unconditionally isn't correct, since the object may 1) not
be extensible or 2) already have a non-configurable "stack" property.

[Yang, 2014-06-27 08:06:59]

On 2014/06/26 14:50:44, Toon Verwaest wrote:
> As discussed offline, I'd drop support for derived objects, this is just too
> annoying.
> 
> Also, setting "stack" unconditionally isn't correct, since the object may 1)
not
> be extensible or 2) already have a non-configurable "stack" property.

Updated. Also fixed some mistakes that snuck in in the last patch set.

[Toon Verwaest, 2014-06-30 09:56:30]

lgtm with some comments

https://codereview.chromium.org/343563009/diff/50001/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/343563009/diff/50001/src/isolate.cc#newcode457
src/isolate.cc:457: JSObject::SetProperty(error_object, key, stack_trace, NONE,
STRICT).Assert();
SetProperty can fail if the object isn't extensible. So if I create a
non-extensible object with a configurable stack property, I'll get the stack
getter/setter, but no hidden symbols to contain the value.

https://codereview.chromium.org/343563009/diff/50001/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/343563009/diff/50001/src/messages.js#newcode1149
src/messages.js:1149: holder = %GetPrototype(holder);
This runs through the prototype chain twice, and the first is just an expensive
"early bailout". I'd rather add after holder = %GetPrototype(holder); if
(!holder) return UNDEFINED;

[Yang, 2014-06-30 11:48:35]

Committed patchset #6 manually as r22089 (presubmit successful).