Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 343563006: X87: Cleanup CallInterfaceDescriptor (Closed)

Created:
6 years, 6 months ago by chunyang.dai
Modified:
6 years, 6 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://github.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

X87: Cleanup CallInterfaceDescriptor port r22014 original commit message: Make CallInterfaceDescriptor work like CodeStubInterfaceDescriptor, owning it's register and representation arrays. This also eliminates a host of TSAN warnings xfor static arrays This CL depends on https://codereview.chromium.org/352583002 landing first (a conceptual dependency at least). BUG=

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -35 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +25 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
chunyang.dai
weiliang. please review this patch. thanks.
6 years, 6 months ago (2014-06-26 07:16:32 UTC) #1
Weiliang
lgtm
6 years, 6 months ago (2014-06-26 07:31:06 UTC) #2
Weiliang
6 years, 6 months ago (2014-06-26 07:35:49 UTC) #3
Committed as r22030

Powered by Google App Engine
This is Rietveld 408576698