Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 343563003: DevTools: beautify the responsive design warning message. (Closed)

Created:
6 years, 6 months ago by pfeldman
Modified:
6 years, 6 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: beautify the responsive design warning message. BUG=327641 NOTRY=true R=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176412

Patch Set 1 #

Patch Set 2 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -46 lines) Patch
M Source/devtools/front_end/ResponsiveDesignView.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/responsiveDesignView.css View 1 chunk +9 lines, -45 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
6 years, 6 months ago (2014-06-18 11:48:33 UTC) #1
dgozman
lgtm
6 years, 6 months ago (2014-06-18 12:09:34 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 6 months ago (2014-06-18 12:11:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/343563003/1
6 years, 6 months ago (2014-06-18 12:12:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 12:12:10 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/devtools/front_end/ResponsiveDesignView.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-18 12:12:11 UTC) #6
pfeldman
6 years, 6 months ago (2014-06-18 12:26:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r176412 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698