Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 343563002: Web Animations API: Avoid style resolution when calling element.animate() (Closed)

Created:
6 years, 6 months ago by alancutter (OOO until 2018)
Modified:
6 years, 6 months ago
Reviewers:
dstockwell, shans
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Web Animations API: Avoid style resolution when calling element.animate() This patch removes a style recalc that occurred every time element.animate() was being called regardless of the input. This is no longer needed now that we are able to defer keyframe resolution the style recalc using DeferredLegacyStyleInterpolation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176485

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : Removed FIXME #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -21 lines) Patch
M LayoutTests/animations/interpolation/font-size-interpolation.html View 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/font-size-interpolation-expected.txt View 2 chunks +14 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/outline-width-interpolation.html View 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/outline-width-interpolation-expected.txt View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/EffectInput.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/EffectInput.cpp View 1 chunk +3 lines, -13 lines 0 comments Download
M Source/core/animation/EffectInputTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
alancutter (OOO until 2018)
This is a continuation of: https://codereview.chromium.org/299073003/
6 years, 6 months ago (2014-06-18 08:30:26 UTC) #1
shans
lgtm
6 years, 6 months ago (2014-06-18 23:45:52 UTC) #2
dstockwell
lgtm https://codereview.chromium.org/343563002/diff/1/Source/core/animation/StringKeyframe.cpp File Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/343563002/diff/1/Source/core/animation/StringKeyframe.cpp#newcode77 Source/core/animation/StringKeyframe.cpp:77: // FIXME: add non-negative CSSPropertyFontSize and CSSPropertyOutlineWidth Looks ...
6 years, 6 months ago (2014-06-19 00:12:20 UTC) #3
alancutter (OOO until 2018)
Will remove FIXME and rebase. https://codereview.chromium.org/343563002/diff/1/Source/core/animation/StringKeyframe.cpp File Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/343563002/diff/1/Source/core/animation/StringKeyframe.cpp#newcode77 Source/core/animation/StringKeyframe.cpp:77: // FIXME: add non-negative ...
6 years, 6 months ago (2014-06-19 03:05:31 UTC) #4
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 6 months ago (2014-06-19 03:23:45 UTC) #5
alancutter (OOO until 2018)
The CQ bit was unchecked by alancutter@chromium.org
6 years, 6 months ago (2014-06-19 03:23:46 UTC) #6
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 6 months ago (2014-06-19 03:23:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/343563002/40001
6 years, 6 months ago (2014-06-19 03:24:50 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 04:32:40 UTC) #9
Message was sent while issue was closed.
Change committed as 176485

Powered by Google App Engine
This is Rietveld 408576698