Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 343543003: Forbid hyphens in *.proto (Closed)

Created:
6 years, 6 months ago by Andrew Hayden (chromium.org)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Nicer output #

Total comments: 1

Patch Set 3 : Extract a function for doing the work as requested #

Total comments: 6

Patch Set 4 : Pawel's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M tools/protoc_wrapper/protoc_wrapper.py View 1 2 3 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Andrew Hayden (chromium.org)
PTAL.
6 years, 6 months ago (2014-06-18 14:27:55 UTC) #1
cjhopman
This lgtm (w/ a minor change). Should get someone who has changes in this stuff ...
6 years, 6 months ago (2014-06-19 20:19:33 UTC) #2
Andrew Hayden (chromium.org)
+pawel. I'll move into a function shortly. Workspace getting a bit gnarly :)
6 years, 6 months ago (2014-06-20 17:38:14 UTC) #3
Andrew Hayden (chromium.org)
Functionified. Functored. Methodized. Generally awesomererified.
6 years, 6 months ago (2014-06-20 17:50:32 UTC) #4
Paweł Hajdan Jr.
https://codereview.chromium.org/343543003/diff/40001/tools/protoc_wrapper/protoc_wrapper.py File tools/protoc_wrapper/protoc_wrapper.py (right): https://codereview.chromium.org/343543003/diff/40001/tools/protoc_wrapper/protoc_wrapper.py#newcode46 tools/protoc_wrapper/protoc_wrapper.py:46: """Scan for bad file names, see crbug/386125 for details. ...
6 years, 6 months ago (2014-06-20 18:38:22 UTC) #5
Andrew Hayden (chromium.org)
PTAL. https://codereview.chromium.org/343543003/diff/40001/tools/protoc_wrapper/protoc_wrapper.py File tools/protoc_wrapper/protoc_wrapper.py (right): https://codereview.chromium.org/343543003/diff/40001/tools/protoc_wrapper/protoc_wrapper.py#newcode46 tools/protoc_wrapper/protoc_wrapper.py:46: """Scan for bad file names, see crbug/386125 for ...
6 years, 6 months ago (2014-06-25 08:40:25 UTC) #6
Paweł Hajdan Jr.
LGTM
6 years, 6 months ago (2014-06-25 19:16:53 UTC) #7
Andrew Hayden (chromium.org)
The CQ bit was checked by andrewhayden@chromium.org
6 years, 6 months ago (2014-06-25 21:19:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andrewhayden@chromium.org/343543003/60001
6 years, 6 months ago (2014-06-25 21:21:43 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-26 02:35:03 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-26 05:57:54 UTC) #11
Message was sent while issue was closed.
Change committed as 279913

Powered by Google App Engine
This is Rietveld 408576698