Issue 343543002: Increase the child process connection timeout for browser tests.

Issue 343543002: Increase the child process connection timeout for browser tests. (Closed)

Created:
6 years, 6 months ago by jam

Modified:
6 years, 6 months ago

Reviewers:
Paweł Hajdan Jr.

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Increase the child process connection timeout for browser tests. Normally a child process kills itself if it can't connect to the browser in 15 seconds. This is to prevent a child process from staying around if the browser crashed right after launching it but before connecting to it. When browser tests are sharded, sometimes tests run slower because of resource starvation which is why we have longer timeouts. So increase the child process connection timeout to match this. BUG=TODO R=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278812

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : rebase #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
M	content/browser/browser_child_process_host_impl.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/child/child_thread.cc	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/common/content_switches.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/test/browser_test_base.cc	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM with a comment. Thanks! https://codereview.chromium.org/343543002/diff/20001/content/public/common/content_switches.cc File content/public/common/content_switches.cc (right): https://codereview.chromium.org/343543002/diff/20001/content/public/common/content_switches.cc#newcode67 content/public/common/content_switches.cc:67: const char kConnectionTimeout[] = ...

6 years, 6 months ago (2014-06-19 18:49:10 UTC) #2

jam

6 years, 6 months ago (2014-06-20 06:45:32 UTC) #3

https://codereview.chromium.org/343543002/diff/20001/content/public/common/co...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/343543002/diff/20001/content/public/common/co...
content/public/common/content_switches.cc:67: const char kConnectionTimeout[]   
         = "connection-timeout";
On 2014/06/19 18:49:10, Paweł Hajdan Jr. wrote:
> Isn't the name a bit too vague? How about child-process-connection-timeout,
and
> also changing the name of the constant? Up to you.

Done, changed to ipc-connection-timeout

Expand Messages | Collapse Messages