Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: dart/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/mobile/MobileLaunchConfigurationDelegate.java

Issue 343533003: Version 1.5.0-dev.4.15 (Closed) Base URL: http://dart.googlecode.com/svn/trunk/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/mobile/MobileLaunchConfigurationDelegate.java
===================================================================
--- dart/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/mobile/MobileLaunchConfigurationDelegate.java (revision 37437)
+++ dart/editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/mobile/MobileLaunchConfigurationDelegate.java (working copy)
@@ -44,6 +44,7 @@
import org.eclipse.debug.core.DebugPlugin;
import org.eclipse.debug.core.ILaunch;
import org.eclipse.debug.core.ILaunchConfiguration;
+import org.eclipse.debug.core.ILaunchManager;
import org.eclipse.debug.core.model.IDebugTarget;
import java.io.IOException;
@@ -122,12 +123,15 @@
private static final int REMOTE_DEBUG_PORT = 9224;
+ private String mode;
+
@Override
public void doLaunch(ILaunchConfiguration configuration, String mode, ILaunch launch,
IProgressMonitor monitor, InstrumentationBuilder instrumentation) throws CoreException {
wrapper = new DartLaunchConfigWrapper(configuration);
wrapper.markAsLaunched();
+ this.mode = mode;
String launchUrl = "";
@@ -250,10 +254,12 @@
throw new MobileUrlConnectionException(launchUrl, localhostOverUsb);
}
- // check if remote connection is alive
- if (!isRemoteConnected()) {
- devBridge.setupPortForwarding(Integer.toString(REMOTE_DEBUG_PORT));
- performRemoteConnection("localhost", REMOTE_DEBUG_PORT, monitor, usePubServe);
+ if (ILaunchManager.DEBUG_MODE.equals(mode)) {
+ // check if remote connection is alive
+ if (!isRemoteConnected()) {
+ devBridge.setupPortForwarding(Integer.toString(REMOTE_DEBUG_PORT));
+ performRemoteConnection("localhost", REMOTE_DEBUG_PORT, monitor, usePubServe);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698