media/cast/transport/cast_transport_sender_impl.cc - Issue 343523005: Cast: Avoid retransmit if we sent the same packet recently (less than RTT)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/transport/cast_transport_sender_impl.cc

Issue 343523005: Cast: Avoid retransmit if we sent the same packet recently (less than RTT) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: store time before send, not after Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/cast/transport/cast_transport_sender.h ('K') | « media/cast/transport/cast_transport_sender_impl.h ('k') | media/cast/transport/pacing/mock_paced_packet_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/transport/cast_transport_sender_impl.cc

diff --git a/media/cast/transport/cast_transport_sender_impl.cc b/media/cast/transport/cast_transport_sender_impl.cc

index 2f51a934e7d60bdea157946e659d3736007db8d6..9b8183f90b557775302735ec705d619303ca52e0 100644

--- a/media/cast/transport/cast_transport_sender_impl.cc

+++ b/media/cast/transport/cast_transport_sender_impl.cc

@@ -178,15 +178,18 @@ void CastTransportSenderImpl::SendRtcpFromRtpSender(

void CastTransportSenderImpl::ResendPackets(

bool is_audio,

const MissingFramesAndPacketsMap& missing_packets,

- bool cancel_rtx_if_not_in_list) {

+ bool cancel_rtx_if_not_in_list,

+ base::TimeDelta rtt) {

if (is_audio) {

DCHECK(audio_sender_) << "Audio sender uninitialized";

audio_sender_->ResendPackets(missing_packets,

- cancel_rtx_if_not_in_list);

+ cancel_rtx_if_not_in_list,

+ rtt);

} else {

DCHECK(video_sender_) << "Video sender uninitialized";

video_sender_->ResendPackets(missing_packets,

- cancel_rtx_if_not_in_list);

+ cancel_rtx_if_not_in_list,

+ rtt);

}