media/cast/transport/rtp_sender/rtp_sender.cc - Issue 343523005: Cast: Avoid retransmit if we sent the same packet recently (less than RTT)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/transport/rtp_sender/rtp_sender.cc

Issue 343523005: Cast: Avoid retransmit if we sent the same packet recently (less than RTT) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: got 500 responses when uploading, uploading again Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/cast/transport/pacing/paced_sender_unittest.cc ('K') | « media/cast/transport/rtp_sender/rtp_sender.h ('k') | media/cast/video_sender/video_sender.cc » ('j') | media/cast/video_sender/video_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/transport/rtp_sender/rtp_sender.cc

diff --git a/media/cast/transport/rtp_sender/rtp_sender.cc b/media/cast/transport/rtp_sender/rtp_sender.cc

index 2604d253de4e3f295163c8f29f9fe78a56445494..20d91cd87f9939d33635e7f11ac080c35f319d0c 100644

--- a/media/cast/transport/rtp_sender/rtp_sender.cc

+++ b/media/cast/transport/rtp_sender/rtp_sender.cc

@@ -75,7 +75,8 @@ void RtpSender::SendFrame(const EncodedFrame& frame) {

void RtpSender::ResendPackets(

const MissingFramesAndPacketsMap& missing_frames_and_packets,

- bool cancel_rtx_if_not_in_list) {

+ bool cancel_rtx_if_not_in_list,

+ base::TimeDelta rtt) {

DCHECK(storage_);

// Iterate over all frames in the list.

for (MissingFramesAndPacketsMap::const_iterator it =

@@ -129,7 +130,7 @@ void RtpSender::ResendPackets(

transport_->CancelSendingPacket(it->first);

}

- transport_->ResendPackets(packets_to_resend);

+ transport_->ResendPackets(packets_to_resend, rtt);

}