media/cast/transport/cast_transport_sender.h - Issue 343523005: Cast: Avoid retransmit if we sent the same packet recently (less than RTT)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/transport/cast_transport_sender.h

Issue 343523005: Cast: Avoid retransmit if we sent the same packet recently (less than RTT) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: got 500 responses when uploading, uploading again Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/cast/transport/cast_transport_sender.h

diff --git a/media/cast/transport/cast_transport_sender.h b/media/cast/transport/cast_transport_sender.h

index 2556a8bd3d7b825a3a8a962b66a099671e0ecfd1..386a3aebba8e4fe5e7ab2775363ff32a296ed148 100644

--- a/media/cast/transport/cast_transport_sender.h

+++ b/media/cast/transport/cast_transport_sender.h

@@ -100,7 +100,8 @@ class CastTransportSender : public base::NonThreadSafe {

virtual void ResendPackets(

Alpha Left Google 2014/06/18 01:43:32 nit: Need a comment to explain what RTT does and w

hubbe 2014/06/18 20:22:27 Done.

bool is_audio,

const MissingFramesAndPacketsMap& missing_packets,

- bool cancel_rtx_if_not_in_list) = 0;

+ bool cancel_rtx_if_not_in_list,

+ base::TimeDelta rtt) = 0;

};

} // namespace transport

« no previous file with comments | « media/cast/rtcp/rtcp_unittest.cc ('k') | media/cast/transport/cast_transport_sender_impl.h » ('j') | media/cast/transport/pacing/paced_sender.h » ('J')