chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc - Issue 343523003: Remove AutocompleteInput Type and PageClassification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

index def498bf53473d9877503872c0b3d4c8d10f081b..f34f3ff59482c3080b341d42e9c5dd807d131d98 100644

--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

@@ -10,7 +10,6 @@

#include "base/threading/sequenced_worker_pool.h"

#include "chrome/browser/autocomplete/autocomplete_classifier.h"

#include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"

-#include "chrome/browser/autocomplete/autocomplete_input.h"

#include "chrome/browser/autocomplete/autocomplete_match.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_notification_types.h"

@@ -30,6 +29,7 @@

#include "chrome/browser/ui/views/tabs/tab_strip.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

+#include "components/metrics/proto/omnibox_event.pb.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/plugin_service.h"

@@ -370,7 +370,7 @@ void BrowserTabStripController::CreateNewTabWithLocation(

// a search query if necessary.

AutocompleteMatch match;

AutocompleteClassifierFactory::GetForProfile(profile())->Classify(

- location, false, false, AutocompleteInput::BLANK, &match, NULL);

+ location, false, false, metrics::OmniboxEventProto::BLANK, &match, NULL);

if (match.destination_url.is_valid())

model_->delegate()->AddTabAt(match.destination_url, -1, true);

}