Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4774)

Unified Diff: chrome/browser/omnibox/omnibox_log.h

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/omnibox/omnibox_field_trial_unittest.cc ('k') | chrome/browser/omnibox/omnibox_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/omnibox/omnibox_log.h
diff --git a/chrome/browser/omnibox/omnibox_log.h b/chrome/browser/omnibox/omnibox_log.h
index 3c641ce4190a7754ec028a72d9c13ae7308aefe9..1923695ac5cf793cba9c63cf3eee5dd74889f32c 100644
--- a/chrome/browser/omnibox/omnibox_log.h
+++ b/chrome/browser/omnibox/omnibox_log.h
@@ -9,9 +9,9 @@
#include "base/strings/string16.h"
#include "base/time/time.h"
-#include "chrome/browser/autocomplete/autocomplete_input.h"
#include "chrome/browser/autocomplete/autocomplete_provider.h"
#include "chrome/browser/sessions/session_id.h"
+#include "components/metrics/proto/omnibox_event.pb.h"
#include "components/metrics/proto/omnibox_input_type.pb.h"
class AutocompleteResult;
@@ -27,7 +27,8 @@ struct OmniboxLog {
size_t selected_index,
bool is_paste_and_go,
SessionID::id_type tab_id,
- AutocompleteInput::PageClassification current_page_classification,
+ metrics::OmniboxEventProto::PageClassification
+ current_page_classification,
base::TimeDelta elapsed_time_since_user_first_modified_omnibox,
size_t completed_length,
base::TimeDelta elapsed_time_since_last_change_to_default_match,
@@ -61,7 +62,7 @@ struct OmniboxLog {
// The type of page (e.g., new tab page, regular web page) that the
// user was viewing before going somewhere with the omnibox.
- AutocompleteInput::PageClassification current_page_classification;
+ metrics::OmniboxEventProto::PageClassification current_page_classification;
// The amount of time since the user first began modifying the text
// in the omnibox. If at some point after modifying the text, the
« no previous file with comments | « chrome/browser/omnibox/omnibox_field_trial_unittest.cc ('k') | chrome/browser/omnibox/omnibox_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698