chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc - Issue 343523003: Remove AutocompleteInput Type and PageClassification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc ('k') | chrome/browser/metrics/omnibox_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc b/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

index 853e1efce865602dc23317357a743bbbcf928b88..8c55774391d285beb16f36b42db7beb9f70a3c08 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/extensions/api/omnibox/omnibox_api_testbase.h"

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/test/base/ui_test_utils.h"

+#include "components/metrics/proto/omnibox_event.pb.h"

// Tests that the autocomplete popup doesn't reopen after accepting input for

@@ -43,7 +44,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, PopupStaysClosed) {

autocomplete_controller->Start(

AutocompleteInput(base::ASCIIToUTF16("keyword command"),

base::string16::npos, base::string16(), GURL(),

- AutocompleteInput::NTP, true, false, true, true));

+ metrics::OmniboxEventProto::NTP, true, false, true,

+ true));

location_bar->AcceptInput();

WaitForAutocompleteDone(autocomplete_controller);

EXPECT_TRUE(autocomplete_controller->done());