chrome/browser/autocomplete/zero_suggest_provider_unittest.cc - Issue 343523003: Remove AutocompleteInput Type and PageClassification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/zero_suggest_provider.h ('k') | chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

diff --git a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

index 14df843a7c24dc82017efdd4b2cdffada2172a99..eebcdfd563aa456b6babf5b8d1c777f001b30b7a 100644

--- a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

+++ b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

@@ -15,6 +15,7 @@

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/common/pref_names.h"

#include "chrome/test/base/testing_profile.h"

+#include "components/metrics/proto/omnibox_event.pb.h"

#include "components/variations/entropy_provider.h"

#include "components/variations/variations_associated_data.h"

#include "content/public/test/test_browser_thread_bundle.h"

@@ -112,7 +113,8 @@ TEST_F(ZeroSuggestProviderTest, TestPsuggestZeroSuggestCachingFirstRun) {

std::string url("http://www.cnn.com");

AutocompleteInput input(

base::ASCIIToUTF16(url), base::string16::npos, base::string16(),

- GURL(url), AutocompleteInput::INVALID_SPEC, true, false, true, true);

+ GURL(url), metrics::OmniboxEventProto::INVALID_SPEC, true, false, true,

+ true);

provider_->Start(input, false);

@@ -141,7 +143,8 @@ TEST_F(ZeroSuggestProviderTest, TestPsuggestZeroSuggestHasCachedResults) {

std::string url("http://www.cnn.com");

AutocompleteInput input(

base::ASCIIToUTF16(url), base::string16::npos, base::string16(),

- GURL(url), AutocompleteInput::INVALID_SPEC, true, false, true, true);

+ GURL(url), metrics::OmniboxEventProto::INVALID_SPEC, true, false, true,

+ true);

// Set up the pref to cache the response from the previous run.

std::string json_response("[\"\",[\"search1\", \"search2\", \"search3\"],"

@@ -187,7 +190,8 @@ TEST_F(ZeroSuggestProviderTest, TestPsuggestZeroSuggestReceivedEmptyResults) {

std::string url("http://www.cnn.com");

AutocompleteInput input(

base::ASCIIToUTF16(url), base::string16::npos, base::string16(),

- GURL(url), AutocompleteInput::INVALID_SPEC, true, false, true, true);

+ GURL(url), metrics::OmniboxEventProto::INVALID_SPEC, true, false, true,

+ true);

// Set up the pref to cache the response from the previous run.

std::string json_response("[\"\",[\"search1\", \"search2\", \"search3\"],"