Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/autocomplete/bookmark_provider_unittest.cc

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/bookmark_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/bookmark_provider_unittest.cc b/chrome/browser/autocomplete/bookmark_provider_unittest.cc
index db7e7fed098958388e3c24ab81922f72e646175d..b3c625d54de0d212e6388670a40b8576e981b39c 100644
--- a/chrome/browser/autocomplete/bookmark_provider_unittest.cc
+++ b/chrome/browser/autocomplete/bookmark_provider_unittest.cc
@@ -20,6 +20,7 @@
#include "components/bookmarks/browser/bookmark_match.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/test/test_bookmark_client.h"
+#include "components/metrics/proto/omnibox_event.pb.h"
#include "testing/gtest/include/gtest/gtest.h"
using bookmarks::BookmarkMatch;
@@ -261,8 +262,8 @@ TEST_F(BookmarkProviderTest, Positions) {
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(query_data); ++i) {
AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),
base::string16::npos, base::string16(), GURL(),
- AutocompleteInput::INVALID_SPEC, false, false,
- false, true);
+ metrics::OmniboxEventProto::INVALID_SPEC, false,
+ false, false, true);
provider_->Start(input, false);
const ACMatches& matches(provider_->matches());
// Validate number of results is as expected.
@@ -338,8 +339,8 @@ TEST_F(BookmarkProviderTest, Rankings) {
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(query_data); ++i) {
AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),
base::string16::npos, base::string16(), GURL(),
- AutocompleteInput::INVALID_SPEC, false, false,
- false, true);
+ metrics::OmniboxEventProto::INVALID_SPEC, false,
+ false, false, true);
provider_->Start(input, false);
const ACMatches& matches(provider_->matches());
// Validate number and content of results is as expected.
@@ -394,8 +395,8 @@ TEST_F(BookmarkProviderTest, InlineAutocompletion) {
" and url=" + query_data[i].url;
AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),
base::string16::npos, base::string16(), GURL(),
- AutocompleteInput::INVALID_SPEC, false, false,
- false, true);
+ metrics::OmniboxEventProto::INVALID_SPEC, false,
+ false, false, true);
const base::string16 fixed_up_input(
provider_->FixupUserInput(input).second);
BookmarkNode node(GURL(query_data[i].url));
@@ -440,8 +441,8 @@ TEST_F(BookmarkProviderTest, StripHttpAndAdjustOffsets) {
std::string description = "for query=" + query_data[i].query;
AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),
base::string16::npos, base::string16(), GURL(),
- AutocompleteInput::INVALID_SPEC, false, false,
- false, true);
+ metrics::OmniboxEventProto::INVALID_SPEC, false,
+ false, false, true);
provider_->Start(input, false);
const ACMatches& matches(provider_->matches());
ASSERT_EQ(1U, matches.size()) << description;
« no previous file with comments | « chrome/browser/autocomplete/base_search_provider.cc ('k') | chrome/browser/autocomplete/builtin_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698