Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: chrome/browser/autocomplete/autocomplete_input.cc

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_input.cc
diff --git a/chrome/browser/autocomplete/autocomplete_input.cc b/chrome/browser/autocomplete/autocomplete_input.cc
index fbf04db017fa5a90c6680d6a57aecba6c324f708..69fd11161b333e1ea78085ee2c5ec75ecc7ffea5 100644
--- a/chrome/browser/autocomplete/autocomplete_input.cc
+++ b/chrome/browser/autocomplete/autocomplete_input.cc
@@ -8,6 +8,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/external_protocol/external_protocol_handler.h"
#include "chrome/browser/profiles/profile_io_data.h"
+#include "components/metrics/proto/omnibox_event.pb.h"
#include "components/url_fixer/url_fixer.h"
#include "content/public/common/url_constants.h"
#include "net/base/net_util.h"
@@ -31,7 +32,7 @@ void AdjustCursorPositionIfNecessary(size_t num_leading_chars_removed,
AutocompleteInput::AutocompleteInput()
: cursor_position_(base::string16::npos),
- current_page_classification_(AutocompleteInput::INVALID_SPEC),
+ current_page_classification_(metrics::OmniboxEventProto::INVALID_SPEC),
type_(metrics::OmniboxInputType::INVALID),
prevent_inline_autocomplete_(false),
prefer_keyword_(false),
@@ -44,7 +45,7 @@ AutocompleteInput::AutocompleteInput(
size_t cursor_position,
const base::string16& desired_tld,
const GURL& current_url,
- AutocompleteInput::PageClassification current_page_classification,
+ metrics::OmniboxEventProto::PageClassification current_page_classification,
bool prevent_inline_autocomplete,
bool prefer_keyword,
bool allow_exact_keyword_match,
@@ -99,7 +100,7 @@ AutocompleteInput::~AutocompleteInput() {
// static
size_t AutocompleteInput::RemoveForcedQueryStringIfNecessary(
- AutocompleteInput::Type type,
+ metrics::OmniboxInputType::Type type,
base::string16* text) {
if ((type != metrics::OmniboxInputType::FORCED_QUERY) || text->empty() ||
(*text)[0] != L'?')
@@ -110,7 +111,8 @@ size_t AutocompleteInput::RemoveForcedQueryStringIfNecessary(
}
// static
-std::string AutocompleteInput::TypeToString(AutocompleteInput::Type type) {
+std::string AutocompleteInput::TypeToString(
+ metrics::OmniboxInputType::Type type) {
switch (type) {
case metrics::OmniboxInputType::INVALID: return "invalid";
case metrics::OmniboxInputType::UNKNOWN: return "unknown";
@@ -124,7 +126,7 @@ std::string AutocompleteInput::TypeToString(AutocompleteInput::Type type) {
}
// static
-AutocompleteInput::Type AutocompleteInput::Parse(
+metrics::OmniboxInputType::Type AutocompleteInput::Parse(
const base::string16& text,
const base::string16& desired_tld,
url::Parsed* parts,
@@ -219,7 +221,7 @@ AutocompleteInput::Type AutocompleteInput::Parse(
url::Parsed http_parts;
base::string16 http_scheme;
GURL http_canonicalized_url;
- AutocompleteInput::Type http_type =
+ metrics::OmniboxInputType::Type http_type =
Parse(http_scheme_prefix + text, desired_tld, &http_parts,
&http_scheme, &http_canonicalized_url);
DCHECK_EQ(std::string(url::kHttpScheme),
@@ -530,7 +532,7 @@ void AutocompleteInput::Clear() {
text_.clear();
cursor_position_ = base::string16::npos;
current_url_ = GURL();
- current_page_classification_ = AutocompleteInput::INVALID_SPEC;
+ current_page_classification_ = metrics::OmniboxEventProto::INVALID_SPEC;
type_ = metrics::OmniboxInputType::INVALID;
parts_ = url::Parsed();
scheme_.clear();
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_input.h ('k') | chrome/browser/autocomplete/autocomplete_input_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698