Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: chrome/browser/autocomplete/autocomplete_result.cc

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_result.cc
diff --git a/chrome/browser/autocomplete/autocomplete_result.cc b/chrome/browser/autocomplete/autocomplete_result.cc
index 000a1fe0185eccb6f7313c052280fd3776fc8aa6..8658f284115e90b4882bcd62c5e5630f53f44465 100644
--- a/chrome/browser/autocomplete/autocomplete_result.cc
+++ b/chrome/browser/autocomplete/autocomplete_result.cc
@@ -16,8 +16,11 @@
#include "chrome/browser/omnibox/omnibox_field_trial.h"
#include "chrome/browser/search/search.h"
#include "chrome/common/autocomplete_match_type.h"
+#include "components/metrics/proto/omnibox_event.pb.h"
#include "components/metrics/proto/omnibox_input_type.pb.h"
+using metrics::OmniboxEventProto;
+
namespace {
// This class implements a special version of AutocompleteMatch::MoreRelevant
@@ -25,7 +28,7 @@ namespace {
class CompareWithDemoteByType {
public:
CompareWithDemoteByType(
- AutocompleteInput::PageClassification current_page_classification);
+ OmniboxEventProto::PageClassification current_page_classification);
// Returns the relevance score of |match| demoted appropriately by
// |demotions_by_type_|.
@@ -40,7 +43,7 @@ class CompareWithDemoteByType {
};
CompareWithDemoteByType::CompareWithDemoteByType(
- AutocompleteInput::PageClassification current_page_classification) {
+ OmniboxEventProto::PageClassification current_page_classification) {
OmniboxFieldTrial::GetDemotionsByType(current_page_classification,
&demotions_);
}
@@ -69,7 +72,7 @@ bool CompareWithDemoteByType::operator()(const AutocompleteMatch& elem1,
class DestinationSort {
public:
DestinationSort(
- AutocompleteInput::PageClassification current_page_classification);
+ OmniboxEventProto::PageClassification current_page_classification);
bool operator()(const AutocompleteMatch& elem1,
const AutocompleteMatch& elem2);
@@ -78,7 +81,7 @@ class DestinationSort {
};
DestinationSort::DestinationSort(
- AutocompleteInput::PageClassification current_page_classification) :
+ OmniboxEventProto::PageClassification current_page_classification) :
demote_by_type_(current_page_classification) {}
bool DestinationSort::operator()(const AutocompleteMatch& elem1,
@@ -364,7 +367,7 @@ GURL AutocompleteResult::ComputeAlternateNavUrl(
}
void AutocompleteResult::DedupMatchesByDestination(
- AutocompleteInput::PageClassification page_classification,
+ OmniboxEventProto::PageClassification page_classification,
bool set_duplicate_matches,
ACMatches* matches) {
DestinationSort destination_sort(page_classification);
@@ -423,7 +426,7 @@ bool AutocompleteResult::HasMatchByDestination(const AutocompleteMatch& match,
}
void AutocompleteResult::MergeMatchesByProvider(
- AutocompleteInput::PageClassification page_classification,
+ OmniboxEventProto::PageClassification page_classification,
const ACMatches& old_matches,
const ACMatches& new_matches) {
if (new_matches.size() >= old_matches.size())

Powered by Google App Engine
This is Rietveld 408576698