chrome/browser/android/omnibox/autocomplete_controller_android.h - Issue 343523003: Remove AutocompleteInput Type and PageClassification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/omnibox/autocomplete_controller_android.h

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/omnibox/autocomplete_controller_android.h

diff --git a/chrome/browser/android/omnibox/autocomplete_controller_android.h b/chrome/browser/android/omnibox/autocomplete_controller_android.h

index 582a3503e98e8ead8fa136250174f4c90db81214..dc378eca0664fb52b192ed6b59cf6a77afca0ef0 100644

--- a/chrome/browser/android/omnibox/autocomplete_controller_android.h

+++ b/chrome/browser/android/omnibox/autocomplete_controller_android.h

@@ -15,6 +15,7 @@

#include "chrome/browser/autocomplete/autocomplete_input.h"

#include "components/keyed_service/content/browser_context_keyed_service_factory.h"

#include "components/keyed_service/core/keyed_service.h"

+#include "components/metrics/proto/omnibox_event.pb.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "content/public/browser/notification_service.h"

@@ -111,7 +112,7 @@ class AutocompleteControllerAndroid : public AutocompleteControllerDelegate,

const AutocompleteResult& autocomplete_result);

// Classifies the type of page we are on.

- AutocompleteInput::PageClassification ClassifyPage(

+ metrics::OmniboxEventProto::PageClassification ClassifyPage(

const GURL& gurl,

bool is_query_in_omnibox,

bool focused_from_fakebox) const;