chrome/browser/autocomplete/bookmark_provider_unittest.cc - Issue 343523003: Remove AutocompleteInput Type and PageClassification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/bookmark_provider_unittest.cc

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_input.h ('K') | « chrome/browser/autocomplete/base_search_provider.cc ('k') | chrome/browser/autocomplete/builtin_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/bookmark_provider_unittest.cc

diff --git a/chrome/browser/autocomplete/bookmark_provider_unittest.cc b/chrome/browser/autocomplete/bookmark_provider_unittest.cc

index db7e7fed098958388e3c24ab81922f72e646175d..28d766cb66eee54052ee9efdca362317fcb86b0b 100644

--- a/chrome/browser/autocomplete/bookmark_provider_unittest.cc

+++ b/chrome/browser/autocomplete/bookmark_provider_unittest.cc

@@ -261,8 +261,8 @@ TEST_F(BookmarkProviderTest, Positions) {

for (size_t i = 0; i < ARRAYSIZE_UNSAFE(query_data); ++i) {

AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),

base::string16::npos, base::string16(), GURL(),

- AutocompleteInput::INVALID_SPEC, false, false,

- false, true);

+ metrics::OmniboxEventProto::INVALID_SPEC, false,

+ false, false, true);

provider_->Start(input, false);

const ACMatches& matches(provider_->matches());

// Validate number of results is as expected.

@@ -338,8 +338,8 @@ TEST_F(BookmarkProviderTest, Rankings) {

for (size_t i = 0; i < ARRAYSIZE_UNSAFE(query_data); ++i) {

AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),

base::string16::npos, base::string16(), GURL(),

- AutocompleteInput::INVALID_SPEC, false, false,

- false, true);

+ metrics::OmniboxEventProto::INVALID_SPEC, false,

+ false, false, true);

provider_->Start(input, false);

const ACMatches& matches(provider_->matches());

// Validate number and content of results is as expected.

@@ -394,8 +394,8 @@ TEST_F(BookmarkProviderTest, InlineAutocompletion) {

" and url=" + query_data[i].url;

AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),

base::string16::npos, base::string16(), GURL(),

- AutocompleteInput::INVALID_SPEC, false, false,

- false, true);

+ metrics::OmniboxEventProto::INVALID_SPEC, false,

+ false, false, true);

const base::string16 fixed_up_input(

provider_->FixupUserInput(input).second);

BookmarkNode node(GURL(query_data[i].url));

@@ -440,8 +440,8 @@ TEST_F(BookmarkProviderTest, StripHttpAndAdjustOffsets) {

std::string description = "for query=" + query_data[i].query;

AutocompleteInput input(base::ASCIIToUTF16(query_data[i].query),

base::string16::npos, base::string16(), GURL(),

- AutocompleteInput::INVALID_SPEC, false, false,

- false, true);

+ metrics::OmniboxEventProto::INVALID_SPEC, false,

+ false, false, true);

provider_->Start(input, false);

const ACMatches& matches(provider_->matches());

ASSERT_EQ(1U, matches.size()) << description;