Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: chrome/browser/android/omnibox/autocomplete_controller_android.h

Issue 343523003: Remove AutocompleteInput Type and PageClassification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_OMNIBOX_AUTOCOMPLETE_CONTROLLER_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_OMNIBOX_AUTOCOMPLETE_CONTROLLER_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_OMNIBOX_AUTOCOMPLETE_CONTROLLER_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_OMNIBOX_AUTOCOMPLETE_CONTROLLER_ANDROID_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/android/jni_weak_ref.h" 10 #include "base/android/jni_weak_ref.h"
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 104
105 // AutocompleteControllerDelegate implementation. 105 // AutocompleteControllerDelegate implementation.
106 virtual void OnResultChanged(bool default_match_changed) OVERRIDE; 106 virtual void OnResultChanged(bool default_match_changed) OVERRIDE;
107 107
108 // Notifies the Java AutocompleteController that suggestions were received 108 // Notifies the Java AutocompleteController that suggestions were received
109 // based on the text the user typed in last. 109 // based on the text the user typed in last.
110 void NotifySuggestionsReceived( 110 void NotifySuggestionsReceived(
111 const AutocompleteResult& autocomplete_result); 111 const AutocompleteResult& autocomplete_result);
112 112
113 // Classifies the type of page we are on. 113 // Classifies the type of page we are on.
114 AutocompleteInput::PageClassification ClassifyPage( 114 metrics::OmniboxEventProto::PageClassification ClassifyPage(
blundell 2014/06/18 16:21:38 nit: Does this not need a new include?
Jun Mukai 2014/06/18 18:01:37 including autocomplete_input.h will include the pr
115 const GURL& gurl, 115 const GURL& gurl,
116 bool is_query_in_omnibox, 116 bool is_query_in_omnibox,
117 bool focused_from_fakebox) const; 117 bool focused_from_fakebox) const;
118 118
119 base::android::ScopedJavaLocalRef<jobject> BuildOmniboxSuggestion( 119 base::android::ScopedJavaLocalRef<jobject> BuildOmniboxSuggestion(
120 JNIEnv* env, const AutocompleteMatch& match); 120 JNIEnv* env, const AutocompleteMatch& match);
121 121
122 // Converts destination_url (which is in its canonical form or punycode) to a 122 // Converts destination_url (which is in its canonical form or punycode) to a
123 // user-friendly URL by looking up accept languages of the current profile. 123 // user-friendly URL by looking up accept languages of the current profile.
124 // e.g. http://xn--6q8b.kr/ --> 한.kr 124 // e.g. http://xn--6q8b.kr/ --> 한.kr
(...skipping 20 matching lines...) Expand all
145 JavaObjectWeakGlobalRef weak_java_autocomplete_controller_android_; 145 JavaObjectWeakGlobalRef weak_java_autocomplete_controller_android_;
146 Profile* profile_; 146 Profile* profile_;
147 147
148 DISALLOW_COPY_AND_ASSIGN(AutocompleteControllerAndroid); 148 DISALLOW_COPY_AND_ASSIGN(AutocompleteControllerAndroid);
149 }; 149 };
150 150
151 // Registers the LocationBar native method. 151 // Registers the LocationBar native method.
152 bool RegisterAutocompleteControllerAndroid(JNIEnv* env); 152 bool RegisterAutocompleteControllerAndroid(JNIEnv* env);
153 153
154 #endif // CHROME_BROWSER_ANDROID_OMNIBOX_AUTOCOMPLETE_CONTROLLER_ANDROID_H_ 154 #endif // CHROME_BROWSER_ANDROID_OMNIBOX_AUTOCOMPLETE_CONTROLLER_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698