Issue 343523002: Refactor cache-updating code to eliminate unnecessary fetches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343523002: Refactor cache-updating code to eliminate unnecessary fetches. (Closed)

Created:
6 years, 6 months ago by szager1

Modified:
6 years, 6 months ago

Reviewers:
agable, iannucci, hinoka

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Refactor cache-updating code to eliminate unnecessary fetches. This is an update of the following reverted change: https://codereview.chromium.org/344443002/ R=hinoka@chromium.org,agable@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=277931

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -18 lines)			Patch
M	gclient_scm.py	View	6 chunks	+19 lines, -13 lines	1 comment	Download
M	git_cache.py	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	2 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

iannucci

lgtm https://codereview.chromium.org/343523002/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/343523002/diff/1/gclient_scm.py#newcode777 gclient_scm.py:777: # HACK(hinoka): These repositories should be super shallow. ...

6 years, 6 months ago (2014-06-17 23:08:17 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/343523002/1

6 years, 6 months ago (2014-06-18 00:50:05 UTC) #4

Message was sent while issue was closed.

Change committed as 277931

Expand Messages | Collapse Messages