Issue 343513003: Restore a document.isActive() check to fix perf regression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343513003: Restore a document.isActive() check to fix perf regression (Closed)

Created:
6 years, 6 months ago by cbiesinger

Modified:
6 years, 6 months ago

Reviewers:
Nate Chapin, abarth-chromium

CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Restore a document.isActive() check to fix perf regression https://codereview.chromium.org/200923002/diff/380001/Source/core/loader/ImageLoader.cpp moved a document.isActive() check elsewhere, leading to us doing more work for non-active documents. This caused a big perf regression for the bloat test. This patch restores that check to fix the regression. BUG=372971 R=japhet@chromium.org CC=yoav@yoav.ws Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176488

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	Source/core/loader/ImageLoader.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbiesinger@chromium.org/343513003/1

6 years, 6 months ago (2014-06-19 03:10:10 UTC) #4

Message was sent while issue was closed.

Change committed as 176488