ui/views/controls/button/blue_button.cc - Issue 343513002: Refactor views::Label and gfx::RenderText shadow functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/blue_button.cc

Issue 343513002: Refactor views::Label and gfx::RenderText shadow functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use simple set_shadows accessors. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/blue_button.cc

diff --git a/ui/views/controls/button/blue_button.cc b/ui/views/controls/button/blue_button.cc

index 8efb0bdc0709c669383105c40598a855a497d5c1..e3a9487ff6cdf7d1d6d207a4f6d96e613fa42b8f 100644

--- a/ui/views/controls/button/blue_button.cc

+++ b/ui/views/controls/button/blue_button.cc

@@ -43,8 +43,8 @@ void BlueButton::ResetColorsFromNativeTheme() {

GetSystemColor(ui::NativeTheme::kColorId_BlueButtonDisabledColor));

// TODO(estade): this is not great on system themes.

- label()->SetShadowColors(kBlueButtonShadowColor, kBlueButtonShadowColor);

- label()->SetShadowOffset(0, 1);

+ label()->set_shadows(gfx::ShadowValues(1,

+ gfx::ShadowValue(gfx::Point(0, 1), 0, kBlueButtonShadowColor)));

}