Issue 343503003: Finish modules build in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343503003: Finish modules build in GN. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
jamesr

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Finish modules build in GN. Add some missing targets and do some minor fixes and additions. Hook up modules and web targets to the build now that they work. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176363

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -9 lines)			Patch
M	Source/build/make_file_arrays.gni	View	1	2 chunks	+15 lines, -2 lines	0 comments	Download
M	Source/config.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/core_generated.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/BUILD.gn	View		4 chunks	+41 lines, -0 lines	0 comments	Download
M	Source/modules/modules.gni	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	Source/modules/modules.gyp	View		6 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/web/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	public/BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #2 manually as r176363.