Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 343473004: [webcrypto] Give more descriptive error messages on Linux for unsupported functionality. (Closed)

Created:
6 years, 6 months ago by eroman
Modified:
6 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[webcrypto] Give more descriptive error messages on Linux for unsupported functionality. * If NSS version doesn't support AES-GCM * If NSS version doesn't support RSA-OAEP BUG=384485 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278364

Patch Set 1 #

Patch Set 2 : rebase onto dependent changelist #

Patch Set 3 : merge parts of dependent CL into this one, for landing first #

Patch Set 4 : add missing reference #

Patch Set 5 : re-apply after revert #

Patch Set 6 : fix test expectation for new error message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M content/child/webcrypto/platform_crypto_nss.cc View 1 2 6 chunks +31 lines, -11 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/status.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/child/webcrypto/status.cc View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
eroman
(Depends on the RSA disabling CL)
6 years, 6 months ago (2014-06-17 19:49:00 UTC) #1
Ryan Sleevi
lgtm
6 years, 6 months ago (2014-06-17 20:49:31 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-18 17:49:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/343473004/60001
6 years, 6 months ago (2014-06-18 17:49:58 UTC) #4
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 6 months ago (2014-06-18 17:50:09 UTC) #5
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-18 17:51:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/343473004/80001
6 years, 6 months ago (2014-06-18 17:54:04 UTC) #7
commit-bot: I haz the power
Change committed as 278230
6 years, 6 months ago (2014-06-19 01:38:06 UTC) #8
jackhou1
A revert of this CL has been created in https://codereview.chromium.org/348493005/ by jackhou@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-19 03:47:05 UTC) #9
eroman
relanding with test fix in patchset 5
6 years, 6 months ago (2014-06-19 07:24:04 UTC) #10
eroman
correction -- patchset 6
6 years, 6 months ago (2014-06-19 07:24:23 UTC) #11
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-06-19 07:24:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/343473004/120001
6 years, 6 months ago (2014-06-19 07:25:08 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 14:41:47 UTC) #14
Message was sent while issue was closed.
Change committed as 278364

Powered by Google App Engine
This is Rietveld 408576698