Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 343473003: Fix overlap on webstore extensions icon in hidpi (Closed)

Created:
6 years, 6 months ago by scottmg
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix overlap on webstore extensions icon in hidpi Previously, when the device scale factor >= 1.5, selects the 2x resource, but then scales it by the DSF. So, for example, at 1.5, it selects 64x64, and draws it as 96x96 pixels, which causes it to overlap. Setting the size explicitly seems to fix it, but I'm not sure if this is the right fix. R=kalman@chromium.org BUG=366377 TEST=manual with --force-device-scale-factor={1,1.25,1.5,2} Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278325

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/extensions/extensions.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
6 years, 6 months ago (2014-06-17 18:53:42 UTC) #1
not at google - send to devlin
I don't know either, this isn't my area. Dan is there any chance you can ...
6 years, 6 months ago (2014-06-18 20:39:48 UTC) #2
Dan Beam
lgtm
6 years, 6 months ago (2014-06-18 20:45:54 UTC) #3
not at google - send to devlin
lgtm
6 years, 6 months ago (2014-06-18 20:46:42 UTC) #4
scottmg
Thanks. I feel like there's probably something at a lower level that should be taking ...
6 years, 6 months ago (2014-06-18 20:50:49 UTC) #5
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 6 months ago (2014-06-18 20:51:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/343473003/1
6 years, 6 months ago (2014-06-18 20:53:36 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 11:26:40 UTC) #8
Message was sent while issue was closed.
Change committed as 278325

Powered by Google App Engine
This is Rietveld 408576698