Source/core/svg/SVGTextPathElement.cpp - Issue 343443003: Remove SVGElement::rendererIsNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGTextPathElement.cpp

Issue 343443003: Remove SVGElement::rendererIsNeeded (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add remaining rendererIsNeeded changes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGTextPathElement.cpp

diff --git a/Source/core/svg/SVGTextPathElement.cpp b/Source/core/svg/SVGTextPathElement.cpp

index 8c42b33d570485456e7da5375ac6faadee618543..5a72697610668b086eb0829c98eaf95e6a830faa 100644

--- a/Source/core/svg/SVGTextPathElement.cpp

+++ b/Source/core/svg/SVGTextPathElement.cpp

@@ -135,7 +135,7 @@ RenderObject* SVGTextPathElement::createRenderer(RenderStyle*)

bool SVGTextPathElement::rendererIsNeeded(const RenderStyle& style)

{

- if (parentNode() && (isSVGAElement(*parentNode()) || isSVGTextElement(*parentNode())))

+ if (parentNode() && (isSVGAElement(*parentNode()) || isSVGTextElement(*parentNode())) && isValid())

esprehn 2014/06/17 23:09:41 Use separate if statements and early returns. if

return Element::rendererIsNeeded(style);

return false;