Source/core/svg/SVGTSpanElement.cpp - Issue 343443003: Remove SVGElement::rendererIsNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGTSpanElement.cpp

Issue 343443003: Remove SVGElement::rendererIsNeeded (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add remaining rendererIsNeeded changes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGTSpanElement.cpp

diff --git a/Source/core/svg/SVGTSpanElement.cpp b/Source/core/svg/SVGTSpanElement.cpp

index 080ca5a66f7cc85ef4e8de51ea9f38189342e24b..66518a511bdd6aafa6284f0c8f74d47d38b1a147 100644

--- a/Source/core/svg/SVGTSpanElement.cpp

+++ b/Source/core/svg/SVGTSpanElement.cpp

@@ -42,15 +42,16 @@ RenderObject* SVGTSpanElement::createRenderer(RenderStyle*)

bool SVGTSpanElement::rendererIsNeeded(const RenderStyle& style)

{

- if (parentNode()

- && (isSVGAElement(*parentNode())

+ if (Node* parent = parentNode()) {

+ if ((isSVGAElement(*parent)

#if ENABLE(SVG_FONTS)

- || isSVGAltGlyphElement(*parentNode())

+ || isSVGAltGlyphElement(*parent)

#endif

- || isSVGTextElement(*parentNode())

- || isSVGTextPathElement(*parentNode())

- || isSVGTSpanElement(*parentNode())))

+ || isSVGTextElement(*parent)

+ || isSVGTextPathElement(*parent)

+ || isSVGTSpanElement(*parent)) && isValid())

return Element::rendererIsNeeded(style);

esprehn 2014/06/17 23:09:40 Remove all the extra parens, instead do: return i

+ }

return false;

}