Source/core/svg/SVGSVGElement.cpp - Issue 343443003: Remove SVGElement::rendererIsNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGSVGElement.cpp

Issue 343443003: Remove SVGElement::rendererIsNeeded (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add remaining rendererIsNeeded changes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGSVGElement.cpp

diff --git a/Source/core/svg/SVGSVGElement.cpp b/Source/core/svg/SVGSVGElement.cpp

index d883e79b316069430e0393eaf58b7609d7cb92f4..eb104580b970a59a9783bf1276eef58018ab866a 100644

--- a/Source/core/svg/SVGSVGElement.cpp

+++ b/Source/core/svg/SVGSVGElement.cpp

@@ -529,6 +529,8 @@ bool SVGSVGElement::rendererIsNeeded(const RenderStyle& style)

// but many things in FrameView and SVGImage depend on the RenderSVGRoot when

// they should instead depend on the RenderView.

// https://bugs.webkit.org/show_bug.cgi?id=103493

+ if (!isValid())

+ return false;

if (document().documentElement() == this)

return true;

return Element::rendererIsNeeded(style);