Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: Source/core/svg/SVGSVGElement.cpp

Issue 343443003: Remove SVGElement::rendererIsNeeded (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add remaining rendererIsNeeded changes Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2007 Apple Inc. All rights reserved.
5 * Copyright (C) 2014 Google, Inc. 5 * Copyright (C) 2014 Google, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 522
523 return transform.multiply(viewBoxTransform); 523 return transform.multiply(viewBoxTransform);
524 } 524 }
525 525
526 bool SVGSVGElement::rendererIsNeeded(const RenderStyle& style) 526 bool SVGSVGElement::rendererIsNeeded(const RenderStyle& style)
527 { 527 {
528 // FIXME: We should respect display: none on the documentElement svg element 528 // FIXME: We should respect display: none on the documentElement svg element
529 // but many things in FrameView and SVGImage depend on the RenderSVGRoot whe n 529 // but many things in FrameView and SVGImage depend on the RenderSVGRoot whe n
530 // they should instead depend on the RenderView. 530 // they should instead depend on the RenderView.
531 // https://bugs.webkit.org/show_bug.cgi?id=103493 531 // https://bugs.webkit.org/show_bug.cgi?id=103493
532 if (!isValid())
533 return false;
532 if (document().documentElement() == this) 534 if (document().documentElement() == this)
533 return true; 535 return true;
534 return Element::rendererIsNeeded(style); 536 return Element::rendererIsNeeded(style);
535 } 537 }
536 538
537 RenderObject* SVGSVGElement::createRenderer(RenderStyle*) 539 RenderObject* SVGSVGElement::createRenderer(RenderStyle*)
538 { 540 {
539 if (isOutermostSVGSVGElement()) 541 if (isOutermostSVGSVGElement())
540 return new RenderSVGRoot(this); 542 return new RenderSVGRoot(this);
541 543
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 } 783 }
782 784
783 void SVGSVGElement::trace(Visitor* visitor) 785 void SVGSVGElement::trace(Visitor* visitor)
784 { 786 {
785 visitor->trace(m_timeContainer); 787 visitor->trace(m_timeContainer);
786 visitor->trace(m_viewSpec); 788 visitor->trace(m_viewSpec);
787 SVGGraphicsElement::trace(visitor); 789 SVGGraphicsElement::trace(visitor);
788 } 790 }
789 791
790 } 792 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698