Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 343443002: Word spacing in RTL for segments (Closed)

Created:
6 years, 6 months ago by Habib Virji
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, leviw+bidiwatch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Word spacing in RTL for segments Removed m_stop and length comparison as they carry different units i.e. if there are two char text then m_stop will be 1 and length 2. As do not compare, needWordSpace does not set correct value. Also by default condition for needSpacing has been changed to true because if first character is space it was getting omitted. BUG=344873 R=leviw, eae TEST=Word spacing in RTL with different segments handling. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176416

Patch Set 1 #

Patch Set 2 : Removed changes of the Inline Iterator and BidiResolver as test fails #

Patch Set 3 : Added antialiased test in test expectaions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/international/bidi-word-spacing-rtl.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/platform/linux/fast/text/international/bidi-word-spacing-rtl-expected.png View 1 Binary file 0 comments Download
A LayoutTests/platform/linux/fast/text/international/bidi-word-spacing-rtl-expected.txt View 1 1 chunk +50 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Habib Virji
Patch#1, include changes for resolving all issues raised in the bug. Patch#2 is simplified version ...
6 years, 6 months ago (2014-06-17 18:39:28 UTC) #1
eae
LGTM++!
6 years, 6 months ago (2014-06-17 19:09:08 UTC) #2
behdad_google
lgtm
6 years, 6 months ago (2014-06-17 19:32:59 UTC) #3
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 6 months ago (2014-06-17 22:27:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/343443002/20001
6 years, 6 months ago (2014-06-17 22:28:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 02:13:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12412)
6 years, 6 months ago (2014-06-18 02:13:37 UTC) #7
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 6 months ago (2014-06-18 11:02:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/343443002/80001
6 years, 6 months ago (2014-06-18 11:02:50 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 13:27:11 UTC) #10
Message was sent while issue was closed.
Change committed as 176416

Powered by Google App Engine
This is Rietveld 408576698