Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 343433008: Use standard compile asserts and offsetof in skia_utils_win.cc. (Closed)

Created:
6 years, 6 months ago by bungeman-chromium
Modified:
6 years, 6 months ago
Reviewers:
bungeman-skia, reed1
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use standard compile asserts and offsetof in skia_utils_win.cc. The current code is causing issues on the "Chromium Win Clang" builder, and also contains redundancies and unneeded repacements for existing function. BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -17 lines) Patch
M skia/ext/skia_utils_win.cc View 1 chunk +11 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
bungeman-skia
6 years, 6 months ago (2014-06-19 17:38:14 UTC) #1
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 6 months ago (2014-06-19 18:15:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bungeman@chromium.org/343433008/1
6 years, 6 months ago (2014-06-19 18:18:22 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 18:18:22 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-19 18:18:23 UTC) #5
reed1
lgtm
6 years, 6 months ago (2014-06-19 18:43:56 UTC) #6
bungeman-chromium
The CQ bit was checked by bungeman@chromium.org
6 years, 6 months ago (2014-06-19 18:44:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bungeman@chromium.org/343433008/1
6 years, 6 months ago (2014-06-19 18:47:10 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-19 23:16:37 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 23:21:29 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/24580)
6 years, 6 months ago (2014-06-19 23:21:29 UTC) #11
bungeman-chromium
The CQ bit was checked by bungeman@chromium.org
6 years, 6 months ago (2014-06-20 01:14:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bungeman@chromium.org/343433008/1
6 years, 6 months ago (2014-06-20 01:16:47 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 05:02:04 UTC) #14
Message was sent while issue was closed.
Change committed as 278602

Powered by Google App Engine
This is Rietveld 408576698