Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 343433005: Show error for invalid url in chrome.app.window.create() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rephrase error message Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/app_window/app_window_api.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index c6623e0532280417d43dfa9d36bc177cafa3a36b..199fbf4b9afcf5c70f65f9c120e15ee1d71df112 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -52,6 +52,8 @@ const char kConflictingBoundsOptions[] =
"The $1 property cannot be specified for both inner and outer bounds.";
const char kAlwaysOnTopPermission[] =
"The \"app.window.alwaysOnTop\" permission is required.";
+const char kInvalidUrlParameter[] =
+ "The URL used for window creation must be local for security reasons.";
} // namespace app_window_constants
const char kNoneFrameOption[] = "none";
@@ -152,10 +154,15 @@ bool AppWindowCreateFunction::RunAsync() {
GURL url = GetExtension()->GetResourceURL(params->url);
// Allow absolute URLs for component apps, otherwise prepend the extension
// path.
- if (GetExtension()->location() == extensions::Manifest::COMPONENT) {
- GURL absolute = GURL(params->url);
- if (absolute.has_scheme())
+ GURL absolute = GURL(params->url);
+ if (absolute.has_scheme()) {
+ if (GetExtension()->location() == extensions::Manifest::COMPONENT) {
url = absolute;
+ } else {
+ // Show error when url passed isn't local.
+ error_ = app_window_constants::kInvalidUrlParameter;
+ return false;
+ }
}
// TODO(jeremya): figure out a way to pass the opening WebContents through to
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698