Issue 343433003: Implemented fake controller pairing flow.

Issue 343433003: Implemented fake controller pairing flow. (Closed)

Created:
6 years, 6 months ago by dzhioev (left Google)

Modified:
6 years, 6 months ago

Reviewers:
Dmitry Polukhin

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implemented fake controller pairing flow. BUG=375191 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278493

Patch Set 2 : Made flow configurable." #

Patch Set 4 : Made confirmation code configurable. #

Patch Set 5 : Fixed GCC compilation. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+444 lines, -2 lines)			Patch
M	chromeos/chromeos.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chromeos/pairing/controller_pairing_flow.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
A	chromeos/pairing/fake_controller_pairing_flow.h	View	1 2 3 4	1 chunk	+111 lines, -0 lines	0 comments	Download
A	chromeos/pairing/fake_controller_pairing_flow.cc	View	1 2 3	1 chunk	+330 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dzhioev (left Google)

Hi, please review. I use this fake for development of pairing UI and I'm going ...

6 years, 6 months ago (2014-06-17 14:32:42 UTC) #1

Dmitry Polukhin

LGTM https://codereview.chromium.org/343433003/diff/1/chromeos/pairing/fake_controller_pairing_flow.cc File chromeos/pairing/fake_controller_pairing_flow.cc (right): https://codereview.chromium.org/343433003/diff/1/chromeos/pairing/fake_controller_pairing_flow.cc#newcode108 chromeos/pairing/fake_controller_pairing_flow.cc:108: confirmation_code_.push_back(base::RandInt('0', '9')); I would avoid randomness in test. ...

6 years, 6 months ago (2014-06-18 10:46:51 UTC) #2

dzhioev (left Google)

The CQ bit was checked by dzhioev@chromium.org

6 years, 6 months ago (2014-06-19 13:56:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/343433003/60001

6 years, 6 months ago (2014-06-19 13:58:22 UTC) #4

dzhioev (left Google)

The CQ bit was checked by dzhioev@chromium.org

6 years, 6 months ago (2014-06-19 17:18:18 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/343433003/80001

6 years, 6 months ago (2014-06-19 17:19:37 UTC) #6

Message was sent while issue was closed.

Change committed as 278493

Expand Messages | Collapse Messages