Issue 343423003: Add noinline for GCC 4.6, which seems to vectorize after inlining.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343423003: Add noinline for GCC 4.6, which seems to vectorize after inlining. (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Add noinline for GCC 4.6, which seems to vectorize after inlining. GCC 4.7 and 4.8 don't need this, but we're not building with them so it doesn't hurt. BUG=skia: Committed: https://skia.googlesource.com/skia/+/b726df472bb996aaab9ea0e62568208599385a1c

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/core/SkConvolver.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/343423003/20001

6 years, 6 months ago (2014-06-25 19:19:09 UTC) #2

commit-bot: I haz the power

6 years, 6 months ago (2014-06-25 19:40:57 UTC) #3

Message was sent while issue was closed.

Change committed as b726df472bb996aaab9ea0e62568208599385a1c