Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 343413002: [MIPS] Add MIPS Android related changes to gn build system (Closed)

Created:
6 years, 6 months ago by gordanac
Modified:
6 years, 6 months ago
Reviewers:
(unused - use chromium), djsollen, Nico, bsalomon, brettw, gordana.cmiljanovic
CC:
chromium-reviews, petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[MIPS] Add MIPS Android related changes to gn build system - Include skia opts files for MIPS - Correct cpu_arch name check - Do not add libgcc using absolute path TEST=Generate ninja files using gn gen and compile targets for mips Android Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279426

Patch Set 1 #

Patch Set 2 : Modified Description. #

Total comments: 2

Patch Set 3 : Correct indentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M build/config/android/config.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +16 lines, -3 lines 0 comments Download
M skia/BUILD.gn View 1 2 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
gordanac
gn gen is currently failing if cpu_arch=mipsel and os=android This change fixes the problem. Please ...
6 years, 6 months ago (2014-06-21 14:48:46 UTC) #1
brettw
lgtm https://codereview.chromium.org/343413002/diff/20001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/343413002/diff/20001/skia/BUILD.gn#newcode637 skia/BUILD.gn:637: "//third_party/skia/src/opts/SkBitmapProcState_opts_none.cpp", Only indent these 2 spaces.
6 years, 6 months ago (2014-06-21 22:32:22 UTC) #2
gordanac
https://codereview.chromium.org/343413002/diff/20001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/343413002/diff/20001/skia/BUILD.gn#newcode637 skia/BUILD.gn:637: "//third_party/skia/src/opts/SkBitmapProcState_opts_none.cpp", On 2014/06/21 22:32:21, brettw wrote: > Only indent ...
6 years, 6 months ago (2014-06-23 08:57:27 UTC) #3
gordanac
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
6 years, 6 months ago (2014-06-23 08:58:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Gordana.Cmiljanovic@imgtec.com/343413002/40001
6 years, 6 months ago (2014-06-23 08:59:31 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-23 11:34:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 11:36:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/75646)
6 years, 6 months ago (2014-06-23 11:36:33 UTC) #8
gordanac
+thakis as I need approval from skia owners.
6 years, 6 months ago (2014-06-23 12:09:14 UTC) #9
gordanac
+ bsalomon@google.com, djsollen@google.com Can someone of skia owners please take a look.
6 years, 6 months ago (2014-06-24 16:13:38 UTC) #10
Nico
skia rslgtm
6 years, 6 months ago (2014-06-24 16:15:30 UTC) #11
gordanac
The CQ bit was checked by gordana.cmiljanovic@imgtec.com
6 years, 6 months ago (2014-06-24 16:37:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Gordana.Cmiljanovic@imgtec.com/343413002/40001
6 years, 6 months ago (2014-06-24 16:38:02 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 17:13:07 UTC) #14
Message was sent while issue was closed.
Change committed as 279426

Powered by Google App Engine
This is Rietveld 408576698