Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Unified Diff: Source/devtools/front_end/ui/UIUtils.js

Issue 343343003: DevTools: [Styles] Add "px" suffix to numbers on arrow up/down (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/CSSMetadata.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/UIUtils.js
diff --git a/Source/devtools/front_end/ui/UIUtils.js b/Source/devtools/front_end/ui/UIUtils.js
index 2e80ca243862dfd84ba2b0803dc2bd901697b001..5d0067e99047a8f424b0a31d3bcae167bb64424a 100644
--- a/Source/devtools/front_end/ui/UIUtils.js
+++ b/Source/devtools/front_end/ui/UIUtils.js
@@ -317,7 +317,7 @@ WebInspector._modifiedFloatNumber = function(number, event)
* @param {!Element} element
* @param {function(string,string)=} finishHandler
* @param {function(string)=} suggestionHandler
- * @param {function(number):number=} customNumberHandler
+ * @param {function(string, number, string):string=} customNumberHandler
* @return {boolean}
*/
WebInspector.handleElementValueModifications = function(event, element, finishHandler, suggestionHandler, customNumberHandler)
@@ -352,10 +352,7 @@ WebInspector.handleElementValueModifications = function(event, element, finishHa
suffix = matches[3];
number = WebInspector._modifiedHexValue(matches[2], event);
- if (customNumberHandler)
- number = customNumberHandler(number);
-
- replacementString = prefix + number + suffix;
+ replacementString = customNumberHandler ? customNumberHandler(prefix, number, suffix) : prefix + number + suffix;
} else {
matches = /(.*?)(-?(?:\d+(?:\.\d+)?|\.\d+))(.*)/.exec(wordString);
if (matches && matches.length) {
@@ -367,10 +364,7 @@ WebInspector.handleElementValueModifications = function(event, element, finishHa
if (number === null)
return false;
- if (customNumberHandler)
- number = customNumberHandler(number);
-
- replacementString = prefix + number + suffix;
+ replacementString = customNumberHandler ? customNumberHandler(prefix, number, suffix) : prefix + number + suffix;
}
}
« no previous file with comments | « Source/devtools/front_end/sdk/CSSMetadata.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698