Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Unified Diff: Source/devtools/front_end/elements/MetricsSidebarPane.js

Issue 343343003: DevTools: [Styles] Add "px" suffix to numbers on arrow up/down (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove "border" and "outline" Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/elements/MetricsSidebarPane.js
diff --git a/Source/devtools/front_end/elements/MetricsSidebarPane.js b/Source/devtools/front_end/elements/MetricsSidebarPane.js
index 2bbdddbd74df62e84bbb87aa9237770a57cc2a69..6208eb0d1618b1dd246a811f34a5c75f3e955cba 100644
--- a/Source/devtools/front_end/elements/MetricsSidebarPane.js
+++ b/Source/devtools/front_end/elements/MetricsSidebarPane.js
@@ -375,11 +375,17 @@ WebInspector.MetricsSidebarPane.prototype = {
this._applyUserInput(element, replacementString, originalValue, context, false);
}
- function customNumberHandler(number)
+ /**
+ * @param {string} prefix
+ * @param {number} number
+ * @param {string} suffix
+ * @return {string}
+ */
+ function customNumberHandler(prefix, number, suffix)
{
if (styleProperty !== "margin" && number < 0)
number = 0;
- return number;
+ return prefix + number + suffix;
}
WebInspector.handleElementValueModifications(event, element, finishHandler.bind(this), undefined, customNumberHandler);

Powered by Google App Engine
This is Rietveld 408576698