Issue 343303003: Add a unit test for WebCore::GlyphBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343303003: Add a unit test for WebCore::GlyphBuffer. (Closed)

Created:
6 years, 5 months ago by jbroman

Modified:
6 years, 5 months ago

Reviewers:
f(malita), eae, eseidel

CC:
blink-reviews, jamesr, krit, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Add a unit test for WebCore::GlyphBuffer. This class is fairly simple, but it's worth taking the rare opportunity to add a unit test to Blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177042

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+238 lines, -0 lines)			Patch
	M	Source/platform/blink_platform.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	Source/platform/fonts/GlyphBufferTest.cpp	View		1 chunk	+237 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

jbroman

This class seems pretty Obviously Correct™, but it's actually independent enough of the rest of ...

6 years, 5 months ago (2014-06-26 14:20:04 UTC) #1

jbroman

win failures are the result of unhappy bots (sync failure due to boringssl) and are ...

6 years, 5 months ago (2014-06-26 14:20:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/343303003/1

6 years, 5 months ago (2014-06-27 00:10:49 UTC) #5

Message was sent while issue was closed.

Change committed as 177042