Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 343273005: Set an empty HTTP origin header if needed in RenderFrame::willSendRequest (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 5 months ago
Reviewers:
jam, ppi
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set an empty HTTP origin header if needed in RenderFrame::willSendRequest This CL sets an empty HTTP origin header if needed in RenderFrame::willSendRequest. This is currently done in FrameFetchContext::addAdditionalRequestHeaders and should go away. BUG=376025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
clamy
@jam, ppi: PTAL
6 years, 6 months ago (2014-06-26 15:39:20 UTC) #1
ppi
lgtm, thanks!
6 years, 6 months ago (2014-06-26 15:59:18 UTC) #2
jam
lgtm
6 years, 6 months ago (2014-06-26 19:26:46 UTC) #3
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 5 months ago (2014-06-30 10:17:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/343273005/1
6 years, 5 months ago (2014-06-30 10:17:35 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-06-30 11:59:03 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 13:57:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/43223)
6 years, 5 months ago (2014-06-30 13:57:05 UTC) #8
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 5 months ago (2014-06-30 14:00:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/343273005/1
6 years, 5 months ago (2014-06-30 14:02:20 UTC) #10
ppi
The CQ bit was unchecked by ppi@chromium.org
6 years, 5 months ago (2014-06-30 14:02:28 UTC) #11
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 5 months ago (2014-07-01 11:55:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/343273005/1
6 years, 5 months ago (2014-07-01 11:55:41 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 11:56:51 UTC) #14
Message was sent while issue was closed.
Change committed as 280802

Powered by Google App Engine
This is Rietveld 408576698