Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 343233004: Add chrome/renderer to the GN build. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
jamesr, abarth-chromium
CC:
avayvod+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, hclam+watch_chromium.org, hguihot+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, mikhal+watch_chromium.org, miu+watch_chromium.org, pwestin+watch_google.com, tfarina
Project:
chromium
Visibility:
Public.

Description

Add chrome/renderer to the GN build. Adds some dependencies, also enables compiling of chrome/common. Adds disable_nacl and safe_browsing feature flags. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278916

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : work around lack of hunspell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+469 lines, -286 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M apps/common/api/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M apps/common/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M build/config/features.gni View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 7 chunks +277 lines, -274 lines 0 comments Download
M chrome/common/BUILD.gn View 1 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 2 1 chunk +133 lines, -0 lines 0 comments Download
M components/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/cast.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A media/cast/logging/proto/BUILD.gn View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
6 years, 6 months ago (2014-06-21 00:15:17 UTC) #1
jamesr
lgtm
6 years, 6 months ago (2014-06-21 00:22:22 UTC) #2
brettw
Committed patchset #3 manually as r278916.
6 years, 6 months ago (2014-06-21 04:29:28 UTC) #3
abarth-chromium
I believe this broke the GN canary on the Blink waterfall: http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/1691
6 years, 6 months ago (2014-06-21 14:06:27 UTC) #4
abarth-chromium
A revert of this CL has been created in https://codereview.chromium.org/346113002/ by abarth@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-21 14:06:53 UTC) #5
abarth-chromium
The revert failed, due to merge conflicts. This issue is blocking the Blink roll. :(
6 years, 6 months ago (2014-06-21 14:10:39 UTC) #6
abarth-chromium
6 years, 6 months ago (2014-06-21 14:25:35 UTC) #7
Message was sent while issue was closed.
Attempting manual partial revert in https://codereview.chromium.org/337823003

Powered by Google App Engine
This is Rietveld 408576698