Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 343183006: Restore image level when setting up image button in AppMenu (Closed)

Created:
6 years, 5 months ago by Ian Wen
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update setupImageButton() in AppMenuAdapter to restore drawable's level after button.setImageDrawable() is called. BUG=386526 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280882

Patch Set 1 #

Patch Set 2 : Revert changes in AppMenuPropertiesDelegate #

Total comments: 2

Patch Set 3 : Restore button image level when setting up #

Total comments: 1

Patch Set 4 : correct typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Ian Wen
Changes in AppMenuPropertiesDelegate have been reverted. Now this patch only deals with issues when updating ...
6 years, 5 months ago (2014-06-30 21:52:14 UTC) #1
aurimas (slooooooooow)
https://codereview.chromium.org/343183006/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java (right): https://codereview.chromium.org/343183006/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java#newcode213 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:213: // Thus we need to remember initial level for ...
6 years, 5 months ago (2014-06-30 21:54:30 UTC) #2
aurimas (slooooooooow)
lgtm after you update CL title and description
6 years, 5 months ago (2014-07-01 16:14:04 UTC) #3
Ian Wen
On 2014/07/01 16:14:04, aurimas wrote: > lgtm after you update CL title and description Yep. ...
6 years, 5 months ago (2014-07-01 16:38:44 UTC) #4
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/343183006/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java (right): https://chromiumcodereview.appspot.com/343183006/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java#newcode213 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:213: // restes drawable to default level. s/restes/resets
6 years, 5 months ago (2014-07-01 16:41:19 UTC) #5
Ian Wen
The CQ bit was checked by ianwen@chromium.org
6 years, 5 months ago (2014-07-01 17:51:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ianwen@chromium.org/343183006/60001
6 years, 5 months ago (2014-07-01 17:52:59 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-01 19:50:26 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-01 19:54:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/26801)
6 years, 5 months ago (2014-07-01 19:54:08 UTC) #10
Ian Wen
The CQ bit was checked by ianwen@chromium.org
6 years, 5 months ago (2014-07-01 20:29:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ianwen@chromium.org/343183006/60001
6 years, 5 months ago (2014-07-01 20:30:22 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 21:12:08 UTC) #13
Message was sent while issue was closed.
Change committed as 280882

Powered by Google App Engine
This is Rietveld 408576698