Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 343183002: [Android] Switch safe browsing to new code path (Closed)

Created:
6 years, 6 months ago by Feng Qian
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Android] Switch safe browsing to new code path The existing safe_browsing=2 only exercises the code path using flywheel protection. safe_browsing=1 uses new code path that combines full safe browsing and flywheel. However, the full safe browsing feature is controlled by Finch experiment. Without Finch experiment setup, the behavior is the same as before, i.e., only Flywheel safe browsing is enabled. BUG=381896 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281991

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (0 generated)
Feng Qian
6 years, 6 months ago (2014-06-20 16:59:39 UTC) #1
sgurun-gerrit only
On 2014/06/20 16:59:39, Feng Qian wrote: lgtm
6 years, 6 months ago (2014-06-20 17:11:11 UTC) #2
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 6 months ago (2014-06-20 17:33:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/343183002/1
6 years, 6 months ago (2014-06-20 17:42:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 21:47:37 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 21:57:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/154453) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/198576)
6 years, 6 months ago (2014-06-20 21:57:35 UTC) #7
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 6 months ago (2014-06-20 22:02:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/343183002/1
6 years, 6 months ago (2014-06-20 22:04:42 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 22:32:35 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 22:42:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/198599)
6 years, 6 months ago (2014-06-20 22:42:49 UTC) #12
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 5 months ago (2014-06-25 16:17:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/343183002/1
6 years, 5 months ago (2014-06-25 16:18:36 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-06-25 17:34:11 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-25 18:57:24 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/166030)
6 years, 5 months ago (2014-06-25 18:57:25 UTC) #17
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 5 months ago (2014-06-26 06:01:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/343183002/1
6 years, 5 months ago (2014-06-26 06:02:57 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-06-26 07:28:52 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-26 08:42:27 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/166263)
6 years, 5 months ago (2014-06-26 08:42:28 UTC) #22
bengr
lgtm
6 years, 5 months ago (2014-06-30 16:29:41 UTC) #23
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 5 months ago (2014-07-09 05:15:11 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/343183002/20001
6 years, 5 months ago (2014-07-09 05:16:36 UTC) #25
commit-bot: I haz the power
6 years, 5 months ago (2014-07-09 07:51:56 UTC) #26
Message was sent while issue was closed.
Change committed as 281991

Powered by Google App Engine
This is Rietveld 408576698