Source/core/rendering/RenderObject.h - Issue 343103003: Flexbox: Allow intrinsic aspect ratios to inform main-size calculation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderObject.h

Issue 343103003: Flexbox: Allow intrinsic aspect ratios to inform main-size calculation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP Patch 3: Addressing comments of WIP Patch 2 Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/css3/flexbox/aspect-ratios-main-size-calculation.html ('K') | « Source/core/rendering/RenderFlexibleBox.cpp ('k') | Source/core/rendering/RenderReplaced.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderObject.h

diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h

index 6a667f49046556f1bd3515cef74466cd123ca674..765b30d9657138ba7afbb3e04891376617264d94 100644

--- a/Source/core/rendering/RenderObject.h

+++ b/Source/core/rendering/RenderObject.h

@@ -553,6 +553,8 @@ public:

bool isSelectionBorder() const;

+ bool hasAspectRatio() const { return isReplaced() && (isImage() || isVideo() || isCanvas()); }

bool hasClip() const { return isOutOfFlowPositioned() && style()->hasClip(); }

bool hasOverflowClip() const { return m_bitfields.hasOverflowClip(); }

bool hasClipOrOverflowClip() const { return hasClip() || hasOverflowClip(); }