Source/core/rendering/RenderFlexibleBox.h - Issue 343103003: Flexbox: Allow intrinsic aspect ratios to inform main-size calculation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFlexibleBox.h

Issue 343103003: Flexbox: Allow intrinsic aspect ratios to inform main-size calculation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP Patch 2 Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/css3/images/resources/green-100x50.png ('k') | Source/core/rendering/RenderFlexibleBox.cpp » ('j') | Source/core/rendering/RenderFlexibleBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderFlexibleBox.h

diff --git a/Source/core/rendering/RenderFlexibleBox.h b/Source/core/rendering/RenderFlexibleBox.h

index 76d13eabc4fe00670c7a96d281827100a4af2399..17ed21058e75be1eb12cab63099d3dd986f531d7 100644

--- a/Source/core/rendering/RenderFlexibleBox.h

+++ b/Source/core/rendering/RenderFlexibleBox.h

@@ -122,6 +122,7 @@ private:

LayoutUnit preferredMainAxisContentExtentForChild(RenderBox* child, bool hasInfiniteLineLength, bool relayoutChildren = false);

bool childPreferredMainAxisContentExtentRequiresLayout(RenderBox* child, bool hasInfiniteLineLength) const;

bool needToStretchChildLogicalHeight(RenderBox* child) const;

+ bool childHasFiniteCrossSize(RenderBox* child) const;

void layoutFlexItems(bool relayoutChildren);

LayoutUnit autoMarginOffsetInMainAxis(const OrderedFlexItemList&, LayoutUnit& availableFreeSpace);

@@ -154,6 +155,7 @@ private:

void alignFlexLines(Vector<LineContext>&);

void alignChildren(const Vector<LineContext>&);

void applyStretchAlignmentToChild(RenderBox*, LayoutUnit lineCrossAxisExtent);

+ void computeAspectRatioOfChild(RenderBox* child, double& aspectRatio, bool& hasAspectRatio);

void flipForRightToLeftColumn();

void flipForWrapReverse(const Vector<LineContext>&, LayoutUnit crossAxisStartEdge);