LayoutTests/css3/flexbox/aspect-ratios-main-size-calculation.html - Issue 343103003: Flexbox: Allow intrinsic aspect ratios to inform main-size calculation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/flexbox/aspect-ratios-main-size-calculation.html

Issue 343103003: Flexbox: Allow intrinsic aspect ratios to inform main-size calculation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP Patch 3: Addressing comments of WIP Patch 2 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <link href="resources/flexbox.css" rel="stylesheet">

	3 <style>

	4 .flexbox {

	5 background-color: #aaa;

	6 }

	7

	8 .flexitem {

	9 background-color:red;

	10 -webkit-aspect-ratio: 1 / 2;

	11 }

	12 </style>

	13 <script src="../../resources/check-layout.js"></script>

	14 <body onload="checkLayout('.flexbox');">

	15 <p>Test for crbug.com/249112: In Flexbox, allow intrinsic aspect ratios to infor m the main-size calculation</p>

	16 <div class="flexbox">

	17 <div class="flexitem" style="height:100px" data-expected-width="50" data-expec ted-height="100"></div>
	tony 2014/08/06 16:37:40 Shouldn't some of the test cases have the flex pro Shouldn't some of the test cases have the flex property set? Without a flex value, I'm not sure what this is testing. Can you copy some of the test cases from Firefox?
	18 </div>

	19

	20 <div class="flexbox" style="height:100px">

	21 <div class="flexitem" style="height:50%" data-expected-width="25" data-expecte d-height="50"></div>

	22 </div>

	23

	24 <div class="flexbox">

	25 <img src="../images/resources/green-100x50.png" style="height:100px" data-expe cted-width="200" data-expected-height="100">

	26 </div>

	27

	28 <div class="flexbox">

	29 <img class="flexitem" src="../images/resources/green-100x50.png" style="height :100px" data-expected-width="50" data-expected-height="100">

	30 </div>

	31

	32 <div class="flexbox" style="height:80px">

	33 <img src="../images/resources/green-100x50.png" style="height:50%" data-expect ed-width="80" data-expected-height="40">

	34 </div>

	35

	36 <div class="flexbox" style="height:40px">

	37 <img src="../images/resources/green-100x50.png" data-expected-width="80" dat a-expected-height="40">

	38 </div>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/css3/flexbox/aspect-ratios-main-size-calculation-expected.txt » ('j') | no next file with comments »